velox icon indicating copy to clipboard operation
velox copied to clipboard

Log eviction when regions age out

Open zacw7 opened this issue 9 months ago • 6 comments

When TTL control ages out old cache entries and evict out the entire regions from a ssd file, it doesn't update log eviction log. So when server recover from checkpoint file, it might see data correctness problem as it might read evicted cache entries on disk which might contain the overwritten data.

zacw7 avatar May 08 '24 23:05 zacw7

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 653aaf9a18ccb87afd893f79e2b4ff35b063a7c4
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6644213ab1b03c0008e2e4de

netlify[bot] avatar May 08 '24 23:05 netlify[bot]

@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 08 '24 23:05 facebook-github-bot

@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 09 '24 20:05 facebook-github-bot

@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 10 '24 21:05 facebook-github-bot

@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 10 '24 21:05 facebook-github-bot

@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 10 '24 22:05 facebook-github-bot

@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 14 '24 22:05 facebook-github-bot

@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 15 '24 02:05 facebook-github-bot

@zacw7 merged this pull request in facebookincubator/velox@eee991b9151348d450fc994ddae717a6de9ae620.

facebook-github-bot avatar May 15 '24 06:05 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit eee991b9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar May 15 '24 07:05 conbench-facebook[bot]