velox icon indicating copy to clipboard operation
velox copied to clipboard

Improve 'insertForJoin' function performance by group prefetching

Open zhli1142015 opened this issue 1 year ago • 2 comments

Apply the prefetching optimization for join probe to function 'insertForJoin' to improve it's performance. Fixes: #9732

zhli1142015 avatar May 07 '24 04:05 zhli1142015

Deploy Preview for meta-velox canceled.

Name Link
Latest commit cc43699a107bcd5ffe3c3964820cd718639066f4
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6645d87a83400a0007b06d9a

netlify[bot] avatar May 07 '24 04:05 netlify[bot]

Verified with join fuzzer for 30 mins.

W0508 12:12:09.084839 3634699 JoinFuzzer.cpp:1232] ==============================> Done with iteration 9585
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

zhli1142015 avatar May 08 '24 04:05 zhli1142015

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 20 '24 21:05 facebook-github-bot

@pedroerp merged this pull request in facebookincubator/velox@0f15532908b7a0423ec9209f029c48c817bd780f.

facebook-github-bot avatar May 21 '24 03:05 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 0f155329.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar May 21 '24 04:05 conbench-facebook[bot]