velox icon indicating copy to clipboard operation
velox copied to clipboard

Remove unused-but-set variables in velox/common/caching/tests/SsdFileTest.cpp +15

Open r-barnes opened this issue 1 year ago • 4 comments

Summary: This diff removes a variable that was set, but which was not used.

LLVM-15 has a warning -Wunused-but-set-variable which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.

Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, please commandeer and make appropriate changes: there are hundreds of these and responding to them individually is challenging.

For questions/comments, contact r-barnes.

  • If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D56887334

r-barnes avatar May 03 '24 19:05 r-barnes

This pull request was exported from Phabricator. Differential Revision: D56887334

facebook-github-bot avatar May 03 '24 19:05 facebook-github-bot

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 80927c7dec00ac201fefff0e4c9704d21e0fab15
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/663d3a0561e97b00088b6bfa

netlify[bot] avatar May 03 '24 19:05 netlify[bot]

This pull request was exported from Phabricator. Differential Revision: D56887334

facebook-github-bot avatar May 03 '24 19:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56887334

facebook-github-bot avatar May 09 '24 21:05 facebook-github-bot

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

stale[bot] avatar Aug 08 '24 03:08 stale[bot]