velox
velox copied to clipboard
Add Presto inverse_weibull_cdf function
Resolves https://github.com/facebookincubator/velox/issues/5495 This is a follow up for https://github.com/facebookincubator/velox/pull/5760
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | 9e973070c8973abb18ed17b91890fc5ca0e42d52 |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/668c0e0ee277130008acac6d |
@wills-feng : Please add the fuzzer output for this function.
There is a on-going discussion about if we need to keep the float test cases in unit test as the result may be different in different time/machine. So still keep it as Draft. Fuzzer test result.
I20240419 10:19:37.930585 27386811 ExpressionFuzzerVerifier.cpp:183] inverse_weibull_cdf 4125611 100.00% 4424083
I20240419 10:19:37.930603 27386811 ExpressionFuzzerVerifier.cpp:196] ==============================> All stats sorted by number of times the function was chosen
I20240419 10:19:37.930619 27386811 ExpressionFuzzerVerifier.cpp:198] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20240419 10:19:37.930635 27386811 ExpressionFuzzerVerifier.cpp:202] inverse_weibull_cdf 4125611 100.00% 4424083
E20240419 10:19:37.930650 27386811 ExpressionFuzzerVerifier.cpp:373] Total iterations: 181904
E20240419 10:19:37.930665 27386811 ExpressionFuzzerVerifier.cpp:374] Total failed: 9420
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[ PASSED ] 0 tests.
@aditi-pandit I refer to Presto Java code base to use round($f()) to avoid the different precision issue. Let me know what you think?
@Yuhta, @kagamiori, @kgpai : Please can you help with the review and merge. These are old PRs for the stats functions blocked because of the bugs in the boost library fixed by Jimmy. https://github.com/boostorg/math/pull/1007
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@pedroerp merged this pull request in facebookincubator/velox@c3839e10a7f5b961a22c579e552ca70d910de0b3.
Conbench analyzed the 1 benchmark run on commit c3839e10.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details.