velox
velox copied to clipboard
Add "get" Spark function
Spark support get
function since v3.4.0, the main difference compared with element_at
is get
is 0-based index and return null when index out of bounds.
Spark ref: https://spark.apache.org/docs/latest/api/sql/index.html#get
Deploy Preview for meta-velox canceled.
Name | Link |
---|---|
Latest commit | dcb2903163a129ed52f40d84c5561d06321d8b67 |
Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/6642c6f6e9940200084744ce |
@rui-mo @PHILO-HE would you help review this PR first?
@mbasmanova would you help review this PR? thank you!
@mbasmanova would you help take a look? thank you!
@Yohahaha Looks good, but CI is red. Please, take a look.
thank you for the review, comments are fixed, but fuzzer job in CI seems broken due to lack resources to execute, I check other merged PR also failed in fuzzer job https://github.com/facebookincubator/velox/pull/9709.
fuzzer job in CI seems broken due to lack resources to execute, I check other merged PR also failed in fuzzer job
@Yohahaha Thank you for checking. Would you create GitHub issue about this if one doesn't exist already? CC: @kgpai @assignUser @majetideepak
fuzzer job in CI seems broken due to lack resources to execute, I check other merged PR also failed in fuzzer job
@Yohahaha Thank you for checking. Would you create GitHub issue about this if one doesn't exist already? CC: @kgpai @assignUser @majetideepak
I opened a issue for this https://github.com/facebookincubator/velox/issues/9744, feel free to close that if the issue has been fixed.
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
hi @kgpai , I have fix conflict, would you help import again? thank you!
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@kgpai merged this pull request in facebookincubator/velox@0e5c0f50e496ea541aaf6615fc5f6b15a13f002b.
Conbench analyzed the 1 benchmark run on commit 0e5c0f50
.
There was 1 benchmark result indicating a performance regression:
- Commit Run on
GitHub-runner-8-core
at 2024-05-15 23:09:42Z
The full Conbench report has more details.