velox icon indicating copy to clipboard operation
velox copied to clipboard

Add "get" Spark function

Open Yohahaha opened this issue 10 months ago • 10 comments

Spark support get function since v3.4.0, the main difference compared with element_at is get is 0-based index and return null when index out of bounds.

Spark ref: https://spark.apache.org/docs/latest/api/sql/index.html#get

Yohahaha avatar Apr 13 '24 10:04 Yohahaha

Deploy Preview for meta-velox canceled.

Name Link
Latest commit dcb2903163a129ed52f40d84c5561d06321d8b67
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6642c6f6e9940200084744ce

netlify[bot] avatar Apr 13 '24 10:04 netlify[bot]

@rui-mo @PHILO-HE would you help review this PR first?

Yohahaha avatar Apr 15 '24 05:04 Yohahaha

@mbasmanova would you help review this PR? thank you!

Yohahaha avatar Apr 15 '24 14:04 Yohahaha

@mbasmanova would you help take a look? thank you!

Yohahaha avatar May 07 '24 01:05 Yohahaha

@Yohahaha Looks good, but CI is red. Please, take a look.

thank you for the review, comments are fixed, but fuzzer job in CI seems broken due to lack resources to execute, I check other merged PR also failed in fuzzer job https://github.com/facebookincubator/velox/pull/9709.

Yohahaha avatar May 08 '24 09:05 Yohahaha

fuzzer job in CI seems broken due to lack resources to execute, I check other merged PR also failed in fuzzer job

@Yohahaha Thank you for checking. Would you create GitHub issue about this if one doesn't exist already? CC: @kgpai @assignUser @majetideepak

mbasmanova avatar May 08 '24 09:05 mbasmanova

fuzzer job in CI seems broken due to lack resources to execute, I check other merged PR also failed in fuzzer job

@Yohahaha Thank you for checking. Would you create GitHub issue about this if one doesn't exist already? CC: @kgpai @assignUser @majetideepak

I opened a issue for this https://github.com/facebookincubator/velox/issues/9744, feel free to close that if the issue has been fixed.

Yohahaha avatar May 08 '24 10:05 Yohahaha

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 09 '24 19:05 facebook-github-bot

hi @kgpai , I have fix conflict, would you help import again? thank you!

Yohahaha avatar May 14 '24 08:05 Yohahaha

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 14 '24 17:05 facebook-github-bot

@kgpai merged this pull request in facebookincubator/velox@0e5c0f50e496ea541aaf6615fc5f6b15a13f002b.

facebook-github-bot avatar May 15 '24 22:05 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 0e5c0f50.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

conbench-facebook[bot] avatar May 15 '24 23:05 conbench-facebook[bot]