velox icon indicating copy to clipboard operation
velox copied to clipboard

Fix scheduled Aggregation fuzzer job which uses presto as source of truth

Open kgpai opened this issue 2 years ago • 4 comments

Eg of failing workflow : https://github.com/facebookincubator/velox/actions/runs/8516830503/job/23327269263 .

As part of migration to GHA, the scheduled aggregation job did not check out Velox , which is fixed in this PR.

kgpai avatar Apr 02 '24 19:04 kgpai

Deploy Preview for meta-velox canceled.

Name Link
Latest commit e1c1ddb226f16f98319faae044f846f58389c2c1
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/660c8e196f2eb80008837643

netlify[bot] avatar Apr 02 '24 19:04 netlify[bot]

Ah sorry, I missed that it uses stuff from scripts.

assignUser avatar Apr 02 '24 22:04 assignUser

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 02 '24 22:04 facebook-github-bot

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 02 '24 23:04 facebook-github-bot

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 05 '24 16:04 facebook-github-bot

@kgpai merged this pull request in facebookincubator/velox@2c1c7d0df0e3f999230049ef164d3a491a1f7ae8.

facebook-github-bot avatar Apr 05 '24 17:04 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 2c1c7d0d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Apr 05 '24 17:04 conbench-facebook[bot]