velox
velox copied to clipboard
facebookincubator
[WIP] Fix partition output flush
The output size was incorrectly estimated in certain cases due to a bug. This was causing flush to happen either too early or too late depending on a query shape.
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | d177f90586853181c7dba9380f130fbc18c6faff |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/66103d0311b1130008ec6e64 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Working on adding a unit test. Considering adding a test case in MultiFragmentTest.
@arhimondr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@arhimondr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@arhimondr merged this pull request in facebookincubator/velox@598895ff5c303264ed36fb27a83778133cd74100.
Conbench analyzed the 1 benchmark run on commit 598895ff.
There was 1 benchmark result indicating a performance regression:
- Commit Run on
GitHub-runner-8-coreat 2024-04-09 17:42:34Z
The full Conbench report has more details.
![conbench-facebook[bot] avatar](https://avatars.githubusercontent.com/in/241235?v=4 "Published by a pub.dev verified publisher"){kind=small}