velox icon indicating copy to clipboard operation
velox copied to clipboard

Add per-test memory sanity check in OperatorTestBase

Open tanjialiang opened this issue 11 months ago • 6 comments

This per test sanity check allows test to reveal failures on test level instead of on the entire suite level. This will greatly reduce the time engineers spent in locating failed tests due to memory leak.

tanjialiang avatar Mar 18 '24 23:03 tanjialiang

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 022590f767612d4c85e63415166ccbd554ff311a
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6615826c8f90cf0008e41213

netlify[bot] avatar Mar 18 '24 23:03 netlify[bot]

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 18 '24 23:03 facebook-github-bot

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 27 '24 03:03 facebook-github-bot

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 27 '24 09:03 facebook-github-bot

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 02 '24 05:04 facebook-github-bot

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 02 '24 16:04 facebook-github-bot

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 08 '24 17:04 facebook-github-bot

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 09 '24 07:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D55043514

facebook-github-bot avatar Apr 09 '24 18:04 facebook-github-bot

@tanjialiang merged this pull request in facebookincubator/velox@845f13ca7827fc9383cd069d541b55fe61f94dcd.

facebook-github-bot avatar Apr 09 '24 20:04 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 845f13ca.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Apr 09 '24 20:04 conbench-facebook[bot]