Remove connector factory registrations

[majetideepak]

We must register connector factories in the client and not in the Velox library.

[netlify[bot]]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	c804611c95925907bc4082a343b930855b7c5b2d
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/66e45270801886000832f0f0

[majetideepak]

@mbasmanova This work was motivated by our discussion here https://github.com/facebookincubator/velox/pull/8765#discussion_r1504212279 where I was trying to add aliases support for a connector factory. However, I realized the HiveConnectorFactory has a constructor that accepts a name for the connector factory and therefore, we don't need the aliases support for the HiveConnectorFactory. But from a Velox library standpoint, we should not be registering the factories in the library. This PR achieves that.

[majetideepak]

@czentgr I addressed your comments. This would be a breaking change. After this lands, we will add the registrations in Prestissimo. I also plan to update the Velox Slack channel.

[majetideepak]

This would change how externals interact with Velox - as in they need to define the connector factories to be used.

External users have to explicitly register the connector factories. This is similar to any other Velox component say functions. No need to define connector factories.

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[majetideepak]

@kgpai Any update on this? Thanks!

[kgpai]

Hi Deepak, Please give me a day or so , hoping to land it soon.

[kevinwilfong]

Spoke with Krishna and he found this PR breaks Presto Native, he sent details to Deepak offline, I'm going to remove the ready-to-merge tag until that's addressed

[kgpai]

@majetideepak Can you fix conflicts , should be good to merge after that..

[majetideepak]

@kgpai this is ready. Can you please import? Thanks.

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kgpai merged this pull request in facebookincubator/velox@74a0db903f92179e3abcf4760e4a46ad5dba331c.

[conbench-facebook[bot]]

Conbench analyzed the 1 benchmark run on commit 74a0db90.

There was 1 benchmark result indicating a performance regression:

• Commit Run on GitHub-runner-8-core at 2024-10-11 17:46:53Z
  • eqBools (C++) with source=cpp-micro, suite=velox_benchmark_basic_comparison_conjunct

The full Conbench report has more details.