velox icon indicating copy to clipboard operation
velox copied to clipboard

Add logic to serialize/deserialize SetAccumulators

Open aditi-pandit opened this issue 1 year ago • 6 comments

This is the second in a set of PRs to add support for spilling distinct aggregations (see full version in https://github.com/facebookincubator/velox/pull/7791).

The logic to serialize/deserialize SetAccumulators is used in the DistinctAggregations for spilling.

aditi-pandit avatar Feb 02 '24 19:02 aditi-pandit

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 9aa2cef2ebea0352be78d5e54a5983e38bc3335b
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6711400a1b3fe40008123db9

netlify[bot] avatar Feb 02 '24 19:02 netlify[bot]

@mbasmanova : Have updated this code post rebase and addressing comments. PTAL.

aditi-pandit avatar Feb 08 '24 03:02 aditi-pandit

@mbasmanova : Have updated the code to serialize to an ARRAY(VARBINARY) instead of a single String buffer. PTAL.

aditi-pandit avatar Feb 29 '24 07:02 aditi-pandit

@xiaoxmeng : Meng, Would appreciate a round of review. Thanks !

aditi-pandit avatar Mar 06 '24 01:03 aditi-pandit

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

stale[bot] avatar Jun 19 '24 21:06 stale[bot]

@xiaoxmeng : Meng, ping for review. Thanks

aditi-pandit avatar Jun 29 '24 00:06 aditi-pandit

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

stale[bot] avatar Oct 17 '24 00:10 stale[bot]