velox
velox copied to clipboard
facebookincubator
Add presto function 'from_base32'
Add presto function 'from_base32'
- Fixes https://github.com/facebookincubator/velox/issues/7294
- Dependencies Create utility file for encoding (https://github.com/facebookincubator/velox/pull/8650)
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | 59797b0bf8b3f165a823a7573aedd25f3c2f87ad |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/663b349b941a3500070467fc |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Joe-Abraham!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
@karteekmurthys , @pramodsatya : Please can you do a first review of this code.
Opened a new PR with e2e testcases, could only be merged after this PR. https://github.com/prestodb/presto/pull/21537
@karteekmurthys , @pramodsatya I have incorporated the changes, can you please resolve the comments and check if the changes are good.
@Joe-Abraham the format check is failing, please make sure to run make format-fix prior to committing.
@Joe-Abraham : Thanks for your contribution.
Don't mean to increase the work.... But would you be able to split your work into 4 individual PRs addressing each of the items (in the PR description) ? That would make it much simpler to review and merge.
@aditi-pandit I have created separate individual PRs for the requirement
Please review the separated PRs https://github.com/facebookincubator/velox/pull/8652 https://github.com/facebookincubator/velox/pull/8651 https://github.com/facebookincubator/velox/pull/8650 https://github.com/facebookincubator/velox/pull/8647 https://github.com/facebookincubator/velox/pull/7672
@czentgr @karteekmurthys @pramodsatya
Let's also make sure we get a fuzzer run with this function and post the result. Step 7 https://github.com/facebookincubator/velox/blob/main/CONTRIBUTING.md#adding-scalar-functions
The CI fuzzer issue has a fix PR that hopefully will be merged soon.
Hi @Joe-Abraham!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with
CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Please sign the CLA. IIRC I signed it as an Individual contributor.
