velox icon indicating copy to clipboard operation
velox copied to clipboard

Add array_cum_sum function

Open pramodsatya opened this issue 1 year ago • 4 comments

Adds Presto array function array_cum_sum. Resolves https://github.com/prestodb/presto/issues/20293 .

pramodsatya avatar Oct 26 '23 00:10 pramodsatya

Deploy Preview for meta-velox canceled.

Name Link
Latest commit ea6431f073d5cbb844813eda3beadef65ca9fdad
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6668cee90709070007123fee

netlify[bot] avatar Oct 26 '23 00:10 netlify[bot]

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

stale[bot] avatar Jan 24 '24 05:01 stale[bot]

@pramodsatya : Please can you rebase and get a clean test run.

aditi-pandit avatar Feb 29 '24 21:02 aditi-pandit

@Yuhta @kagamiori : Would be great to get your review/merge help.

aditi-pandit avatar Mar 27 '24 19:03 aditi-pandit

Hi @pramodsatya it looks like we lost track of this change as it was never merged, could you rebase and update the PR?

kevinwilfong avatar Jun 10 '24 17:06 kevinwilfong

Hi @pramodsatya it looks like we lost track of this change as it was never merged, could you rebase and update the PR?

Hi @kevinwilfong, I have rebased the PR, thanks for helping with the merge.

pramodsatya avatar Jun 10 '24 18:06 pramodsatya

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 10 '24 22:06 facebook-github-bot

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 13 '24 18:06 facebook-github-bot

@kevinwilfong merged this pull request in facebookincubator/velox@79bc73def5622d4659cde46f4249fef3e45726c9.

facebook-github-bot avatar Jun 14 '24 06:06 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 79bc73de.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Jun 14 '24 07:06 conbench-facebook[bot]