velox icon indicating copy to clipboard operation
velox copied to clipboard

Folly recompilation making nightly Fuzzer job to timeout

Open pedroerp opened this issue 2 years ago • 5 comments

Folly is now being recompiled by "make fuzzertest", causing the fuzzer binary to also recompile and the whole job to timeout. This is an example of the failure:

https://app.circleci.com/pipelines/github/facebookincubator/velox/14386/workflows/0ac4c994-82a8-4961-aaae-f03ebf41c49b/jobs/87226

Check the "Run Fuzzer Test" tab. It should simply run the binary compiled in the "Build" step, but its now recompiling the whole thing. This is an older execution of the job, when it worked as expected:

https://app.circleci.com/pipelines/github/facebookincubator/velox/14291/workflows/1ac62135-31b7-4246-9238-13c8bcfaa4fc/jobs/86588

pedroerp avatar Oct 06 '22 01:10 pedroerp

CC: @majetideepak

mbasmanova avatar Oct 06 '22 01:10 mbasmanova

cc @raulcd . We should investigate if the recent folly changes have caused fuzzer-test to recompile.

kgpai avatar Oct 06 '22 16:10 kgpai

FYI, I notice that without enabling Arrow, I see that build is not triggered for fuzzer-tests and it runs fine. Enabling Arrow is mainly for Parquet and we install thrift/arrow , which itself uses external project add and all that is probably not playing well with folly. Would it be ok to build this without enabling arrow ? I dont think fuzzer tests requires it if I am not mistaken.

kgpai avatar Oct 06 '22 20:10 kgpai

I don't see any reason why arrow should be enabled on that job. Feel free to remove that flag.

pedroerp avatar Oct 07 '22 04:10 pedroerp

The error below is often due to the compilation job running out of memory. Reducing the build parallelism should work. Removing unnecessary dependencies is always the best way.

collect2: fatal error: ld terminated with signal 9 [Killed]
compilation terminated.

majetideepak avatar Oct 07 '22 15:10 majetideepak