velox icon indicating copy to clipboard operation
velox copied to clipboard

[CMake] Modernize boost package uses

Open ManManson opened this issue 2 years ago • 5 comments

Use Boost::-prefixed imported targets when linking boost libraries to velox libs instead of using old-style Boost_XYZ_LIBRARIES variables.

Signed-off-by: Pavel Solodovnikov [email protected]

ManManson avatar Sep 16 '22 07:09 ManManson

Deploy Preview for meta-velox canceled.

Name Link
Latest commit fab2145c06e4d8906177a1c140ac26b7b3f7bcb8
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6331869cab8e9f0008dd4bad

netlify[bot] avatar Sep 16 '22 07:09 netlify[bot]

Force-pushed the branch to fix formatting issues reported by an automated CI check. The diff can be found here: https://github.com/facebookincubator/velox/compare/2f94dc4b8cae767d269729cc84a952242c98defe..a739862ff0d9c56d22b4cce79a69ea465d5908f1

ManManson avatar Sep 16 '22 07:09 ManManson

Force-pushed (rebase to main) to resolve conflicts. @kgpai Polite review ping.

ManManson avatar Sep 26 '22 11:09 ManManson

Review ping^2.

ManManson avatar Oct 06 '22 17:10 ManManson

Review ping^3. The benchmark regressions surely are unrelated to the change. Is there anything else to be done to make progress with this?

ManManson avatar Oct 20 '22 13:10 ManManson

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

stale[bot] avatar Jan 18 '23 23:01 stale[bot]