velox icon indicating copy to clipboard operation
velox copied to clipboard

Some code refactors to support hash join spill in followup

Open xiaoxmeng opened this issue 2 years ago • 11 comments

  • Add to expose some fields in hash function which will be used for recursive hash control later
  • Refactor HashBuild a bit by putting hash table build logic into a separate function which will be reused in partition restore path

xiaoxmeng avatar Aug 29 '22 17:08 xiaoxmeng

Deploy Preview for meta-velox canceled.

Name Link
Latest commit c4187cc231f794e7fa78d950f9284324c88d8a26
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/630e455de752620008ad42c1

netlify[bot] avatar Aug 29 '22 17:08 netlify[bot]

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 17:08 facebook-github-bot

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 17:08 facebook-github-bot

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 17:08 facebook-github-bot

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 20:08 facebook-github-bot

@xiaoxmeng There are CI failures. Please, take a look.

mbasmanova avatar Aug 29 '22 21:08 mbasmanova

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 22:08 facebook-github-bot

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 22:08 facebook-github-bot

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 22:08 facebook-github-bot

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 30 '22 05:08 facebook-github-bot

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 30 '22 17:08 facebook-github-bot