velox Handle decimal to decimal cast overflow condition

Handle decimal to decimal cast overflow condition

Open karteekmurthys opened this issue 2 years ago • 1 comments

Aug 27 '22 06:08 karteekmurthys

Name	Link
Latest commit	204b6f958b6d1c1887a45a47f53143ded33b212a
Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/6317e0e11841c10008b4f050

Aug 27 '22 06:08 netlify[bot]

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Aug 30 '22 22:08 facebook-github-bot

It looks like there's a conflict with trunk, could you please rebase?

Aug 30 '22 22:08 kevinwilfong

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Aug 30 '22 23:08 facebook-github-bot

I have the internal tests all passing except for the issue I highlighted above.

Also it looks like there are a couple unresolved comments still from others "add test for null on failure." "Can you also try for min() ?"

If you can help address these I can land this PR.

Sep 06 '22 18:09 kevinwilfong

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sep 07 '22 20:09 facebook-github-bot