velox icon indicating copy to clipboard operation
velox copied to clipboard
verified publisher icon facebookincubator

Add decimal types support to VELOX_DYNAMIC_TYPE_DISPATCH_IMPL

Open majetideepak opened this issue 3 years ago • 3 comments

A lack of VELOX_DYNAMIC_TYPE_DISPATCH_IMPL support for decimal types requires specialization for these types at various code blocks. This is now supported.

majetideepak avatar Aug 16 '22 20:08 majetideepak

CC: @karteekmurthys

majetideepak avatar Aug 16 '22 20:08 majetideepak

@kgpai, @Yuhta can someone please merge this? Thanks.

majetideepak avatar Aug 18 '22 17:08 majetideepak

@laithsakka has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 25 '22 14:08 facebook-github-bot

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 9b4d659a4bff180b193bd61aaa7c07fe69287b03
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/631798f6f165450008be9de0

netlify[bot] avatar Aug 30 '22 18:08 netlify[bot]

@laithsakka @kgpai can you please import this again? I had to rebase due to a conflict with the main branch. Thanks.

majetideepak avatar Aug 30 '22 18:08 majetideepak

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 31 '22 20:08 facebook-github-bot

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 06 '22 20:09 facebook-github-bot