velox
velox copied to clipboard
facebookincubator
Fix min_by(date, date), max_by(date, date) aggregate function
Fix initialization and add support for min_by, max_by aggregates for date datatype.
@xiaoxmeng could you help review this PR since you recently changed this function?
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | 2cafd96aa0de822ea28ab1c73dd21bed06b5744d |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/6317f55d3e5584000886b670 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@pramodsatya Thank you for the fix. CI is failing. Would you take a look?
@pramodsatya Pramod, thank you for updating the PR description. It is much easier to understand the changes now. Would you also format the PR description to wrap at 80 characters? BTW, do we now have tests that fail without the fix?
Sure, will update the description, thanks! Currently, we do not have tests that fail without the fix, the tests for DATE have also been added in this PR and these tests do fail without the fix.
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.