velox icon indicating copy to clipboard operation
velox copied to clipboard

Update coding style with test method annotation

Open xiaoxmeng opened this issue 2 years ago • 1 comments

Update coding style with test method annotation, e.g. if we want to add a test method say 'foo' to an object, we will name it with prefix TEST, TEST_foo.

xiaoxmeng avatar Aug 02 '22 23:08 xiaoxmeng

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 02 '22 23:08 facebook-github-bot

Deploy Preview for meta-velox canceled.

Name Link
Latest commit d52f8bfb49cacdbf524c38fff2dace2b36fa125b
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/63e55bd1e7f2da0008d8235d

netlify[bot] avatar Aug 31 '22 05:08 netlify[bot]

Is this PR still being worked on ?

aditi-pandit avatar Sep 02 '22 06:09 aditi-pandit

This pull request was exported from Phabricator. Differential Revision: D38372050

facebook-github-bot avatar Feb 09 '23 19:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D38372050

facebook-github-bot avatar Feb 09 '23 20:02 facebook-github-bot

@xiaoxmeng merged this pull request in facebookincubator/velox@47b84235942893cc1e9759171e7fd21fd167a545.

facebook-github-bot avatar Feb 09 '23 21:02 facebook-github-bot