velox icon indicating copy to clipboard operation
velox copied to clipboard

Implement Filter::mergeWith for BytesRange and BytesValue

Open mbasmanova opened this issue 3 years ago • 2 comments

Filter::mergeWith API is used to merge filters pushed down from the join to topN operators into collocated table scan. Currently this API is implemented for numeric types. This task is to implement the API for strings.

https://github.com/facebookincubator/velox/pull/119 PR introduced Filter::mergeWith() API with implementation for numeric types.

https://github.com/facebookincubator/velox/pull/103 introduced filter pushdown that uses Filter::mergeWith() API.

CC: @pedroerp @aditi-pandit @majetideepak

mbasmanova avatar Sep 02 '21 15:09 mbasmanova

CC: @kgpai

mbasmanova avatar Sep 02 '21 15:09 mbasmanova

This issue has been automatically marked as stale because it has not had any activity in the last year. If you feel that this issue is important, add a comment explaining why the issue is still relevant and the stale tag will be removed; otherwise it will be closed in 14 days. This is an attempt to ensure that our open issues remain valuable and relevant so that we can keep track of what needs to be done and prioritize the right things.

stale[bot] avatar Sep 11 '22 01:09 stale[bot]

@mbasmanova Could you please assign this issue to me?

HannanKan avatar Mar 19 '23 14:03 HannanKan

I think this issue can close because it has finished in https://github.com/facebookincubator/velox/pull/297.

rterror avatar Jun 07 '23 05:06 rterror