velox Throw for zzzz (and beyond) in parse

Throw for zzzz (and beyond) in parse_datetime

Open kevinwilfong opened this issue 1 year ago • 4 comments

Summary: This diff throws a user exception for JODA's zzzz (or more) patterns (all equivalent) in Presto's parse_datetime function.

JODA does not support parsing time zone long names (specified by the pattern zzzz) so neither should Velox to be consistent. Previously we were treating any number of 'z's as representing a time zone abbreviation in the pattern which is completely wrong.

Differential Revision: D64797504

Oct 22 '24 23:10 kevinwilfong

Deploy Preview for meta-velox canceled.

Name	Link
Latest commit	1d48ef6fbfec5a10acad6df7e7f33308f7dbde49
Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/67210fc7339d6c0008510973

Oct 22 '24 23:10 netlify[bot]

This pull request was exported from Phabricator. Differential Revision: D64797504

Oct 22 '24 23:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64797504

Oct 24 '24 21:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64797504

Oct 24 '24 21:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64797504

Oct 29 '24 16:10 facebook-github-bot

This pull request has been merged in facebookincubator/velox@3bcc5f385e6c011d0441130f9d07a82780b9f25d.

Oct 29 '24 19:10 facebook-github-bot

velox velox copied to clipboard

Throw for zzzz (and beyond) in parse_datetime

✅ Deploy Preview for meta-velox canceled.

velox
velox copied to clipboard

Deploy Preview for meta-velox canceled.