velox icon indicating copy to clipboard operation
velox copied to clipboard

Published 20 hours ago • verified publisher icon facebookincubator

Remove usage of GTest Throws in dwrf::ColumnWriterTest.cpp

Open majetideepak opened this issue 1 year ago • 4 comments

Gtest feature Throws is available in GTest 1.11 while system default in Ubuntu 20.04 is GTest 1.10 Remove usage instead of enforcing a GTest minimum version.

majetideepak avatar Oct 16 '24 11:10 majetideepak

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 5a924ed8dca035f2b15da3c2009c70e7cf332829
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6712e20e452f860008af95f7

netlify[bot] avatar Oct 16 '24 11:10 netlify[bot]

@majetideepak There are more instances of this Throws usage. e.g. in StripeReaderBaseTests.cpp:131. Checking where else.

Edit: OnDemandUnitLoaderTests.cpp:142

czentgr avatar Oct 16 '24 18:10 czentgr

@czentgr I found a few others and fixed them.

majetideepak avatar Oct 16 '24 19:10 majetideepak

@kgpai can you please help review and merge this?

majetideepak avatar Oct 22 '24 22:10 majetideepak

Thanks @majetideepak

pedroerp avatar Oct 28 '24 15:10 pedroerp

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Oct 28 '24 15:10 facebook-github-bot

@pedroerp merged this pull request in facebookincubator/velox@2e381e48ca07d2869e6644e75e1c079dc3ad85c9.

facebook-github-bot avatar Oct 28 '24 17:10 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 2e381e48.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Oct 28 '24 17:10 conbench-facebook[bot]