velox
velox copied to clipboard
Fix security vulnerabilities
IBM code scan found a few issues.
- Use of uninitialized variables: It is always safe to initialize variables. Most instances fixed in the PR get initialized in a function but depending on a function is unsafe.
- Detect and handle memory allocation errors
- Bitwise operations (~, <<, >>, &, ^ and |) and their combinations with assign operator (<<=, >>=, &=, ^= and |=) are not normally meaningful on signed integers. Bitwise operators should be used only with unsigned integer operands, as the result of bitwise operations on signed integers are implementation-defined.
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | b404ab5830393086a85cfdf28f712be9f69aec72 |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/67115d2c35a5df000899dcac |
Thanks @majetideepak ! Is it possible to add what cve's this fixes ?
@kgpai I updated the description. Thanks!
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@kgpai merged this pull request in facebookincubator/velox@878388f706e56abd3da6df6727e5496bdc577411.
Conbench analyzed the 1 benchmark run on commit 878388f7.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details.