velox icon indicating copy to clipboard operation
velox copied to clipboard

Update Base64 as a non-throwing API

Open Joe-Abraham opened this issue 1 year ago • 5 comments

Follow-up PR: https://github.com/facebookincubator/velox/pull/10371

The following changes are done in this PR.

  1. Refactor the APIs in Base64 as non-throwing APIs.

Changing the char to std::string_view and std::string will be done in subsequent PR.

Joe-Abraham avatar Oct 02 '24 17:10 Joe-Abraham

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 03fc98d2760c16006398cb6a1e51f8e19a566599
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67e6727d1aaa8c00083709b7

netlify[bot] avatar Oct 02 '24 17:10 netlify[bot]

@majetideepak Can you please review the changes?

Joe-Abraham avatar Oct 03 '24 11:10 Joe-Abraham

Thanks @Joe-Abraham , based on brief glance, it seems its mostly renaming variables etc for readability and consistency (which is welcome change); Want to make sure I am not missing any material change.

kgpai avatar Oct 11 '24 06:10 kgpai

@kgpai I have also made the APIs used in BinaryFunctions.h as non-throwing.

Joe-Abraham avatar Oct 11 '24 06:10 Joe-Abraham

  1. Refactor the APIs in Base64 as non-throwing APIs.

@Joe-Abraham this should be its own PR since its a functional change. We can leave the remaining code improvements this PR. Can you please open another PR with only the non-throwing API changes? Thanks.

majetideepak avatar Oct 18 '24 09:10 majetideepak

@Joe-Abraham can you add a brief description of how this change can help with performance? I think Masha's original motivation was to see benefits similar to TRY(CAST()) as explained here https://velox-lib.io/blog/optimize-try-more/

majetideepak avatar Mar 19 '25 10:03 majetideepak

@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 02 '25 11:04 facebook-github-bot

@bikramSingh91 merged this pull request in facebookincubator/velox@c9bbd66230f2714015b63b220a5983b59cf5a2d3.

facebook-github-bot avatar Apr 03 '25 04:04 facebook-github-bot