velox icon indicating copy to clipboard operation
velox copied to clipboard

Published 20 hours ago • verified publisher icon facebookincubator

Add IPPREFIX type

Open mohsaka opened this issue 1 year ago • 4 comments

This PR only adds the IPPrefix type classes. CAST logic is not implemented. The next PR for IPPrefix type will enhance the fuzzers for IPPrefix type. After that we will add the CAST logic so that it can be tested with fuzzers from the start itself.

The full logic for IPPrefix is available in PRs : Original PR: https://github.com/facebookincubator/velox/pull/10538 Original Split PR: https://github.com/facebookincubator/velox/pull/10816

mohsaka avatar Sep 27 '24 23:09 mohsaka

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 96c3bc4d3faa12b897be23f869e6f1623661e90a
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/670f1be132460a0008c875e6

netlify[bot] avatar Sep 27 '24 23:09 netlify[bot]

@aditi-pandit @czentgr Can I get a review on this? Thank you!

mohsaka avatar Sep 30 '24 18:09 mohsaka

@Yuhta Could I get a review please. Thanks you!

mohsaka avatar Oct 16 '24 18:10 mohsaka

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Oct 24 '24 18:10 facebook-github-bot

@pedroerp merged this pull request in facebookincubator/velox@c8ac4e3aa4ca1eb5f0c1932ea22d5612aab146eb.

facebook-github-bot avatar Oct 28 '24 18:10 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit c8ac4e3a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Oct 28 '24 18:10 conbench-facebook[bot]