velox icon indicating copy to clipboard operation
velox copied to clipboard

Support reading plain encoded INT96 timestamp from Parquet file

Open rui-mo opened this issue 1 year ago • 3 comments

Follow-up for: https://github.com/facebookincubator/velox/pull/4680.

rui-mo avatar Aug 27 '24 02:08 rui-mo

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 316bf01134b65160061a6fca977387372a9ab45a
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673164d2db5126000895f227

netlify[bot] avatar Aug 27 '24 02:08 netlify[bot]

Hi @mskapilks, since Gluten customer has been asking for this feature, I created this PR to add support for reading plain encoded INT96 timestamp with your commit kept. If you would like to continue this work in your PR, please let us know. Thanks!

rui-mo avatar Aug 27 '24 02:08 rui-mo

Hi @mskapilks, since Gluten customer has been asking for this feature, I created this PR to add support for reading plain encoded INT96 timestamp with your commit kept. If you would like to continue this work in your PR, please let us know. Thanks!

Thanks for the PR You can continue. I am still looking into INT64 pr

mskapilks avatar Aug 27 '24 06:08 mskapilks

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Nov 08 '24 21:11 facebook-github-bot

@kevinwilfong This PR might need to be re-imported before merging. Thanks for your help.

rui-mo avatar Nov 11 '24 06:11 rui-mo

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Nov 11 '24 17:11 facebook-github-bot

@kevinwilfong merged this pull request in facebookincubator/velox@da39954c22f1dda1d4b78dae078fb1307fc2508f.

facebook-github-bot avatar Nov 12 '24 18:11 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit da39954c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Nov 12 '24 18:11 conbench-facebook[bot]

@Yuhta @majetideepak Thank you for helping review this PR.

rui-mo avatar Nov 13 '24 01:11 rui-mo