velox
velox copied to clipboard
facebookincubator
Rewrite some common reduce patterns with array_sum and transform
Summary:
Lambda expression in Velox is interpreted instead of compiled like in
Presto Java, this makes us losing in performance in places like reduce. By
rewriting some common patterns of reduce, we improve the performance
significantly (more than 45x on a query).
Also fix a bug in TryExpr where we are not checking enough space for result
nulls.
Differential Revision: D59406443
Deploy Preview for meta-velox canceled.
| Name | Link |
|---|---|
| Latest commit | 8842fcc8785953f46d1c23fd8960bd518b096285 |
| Latest deploy log | https://app.netlify.com/sites/meta-velox/deploys/668c58aa5badc00008258160 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been merged in facebookincubator/velox@19be763371d6caaf8d0880b6c8920fb28358cf92.
Conbench analyzed the 1 benchmark run on commit 19be7633.
There were no benchmark performance regressions. 🎉
The full Conbench report has more details.
![conbench-facebook[bot] avatar](https://avatars.githubusercontent.com/in/241235?v=4 "Published by a pub.dev verified publisher"){kind=small}