velox icon indicating copy to clipboard operation
velox copied to clipboard

Fix snake_case naming codestyle in Filter

Open lingbin opened this issue 1 year ago • 1 comments

is_deterministic -> deterministic

Velox do not use 'snake_case' for local variables.

No functional changes.

lingbin avatar Jul 05 '24 12:07 lingbin

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 3ff10564037089e1327baf67d65b30a1085f5ab7
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6687e4d126f89e0008bdb157

netlify[bot] avatar Jul 05 '24 12:07 netlify[bot]

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 09 '24 00:07 facebook-github-bot

@pedroerp merged this pull request in facebookincubator/velox@fe73db8c26fee7239d3ea4a5deea1ad02a1ec7cb.

facebook-github-bot avatar Jul 09 '24 18:07 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit fe73db8c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Jul 09 '24 19:07 conbench-facebook[bot]