velox icon indicating copy to clipboard operation
velox copied to clipboard

Quote the variables in `start-spark.sh` and `start-prestojava.sh`

Open rui-mo opened this issue 1 year ago • 2 comments

Quote the variables in shell script to prevent globbing and word splitting. https://github.com/koalaman/shellcheck/wiki/SC2086

rui-mo avatar Jul 03 '24 00:07 rui-mo

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 42c1b2859d05251ac54ca27c5f0ec68a88f7f2d8
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66849ff4fa04520008cf75e3

netlify[bot] avatar Jul 03 '24 00:07 netlify[bot]

cc: @bikramSingh91 Thanks.

rui-mo avatar Jul 03 '24 00:07 rui-mo

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 08 '24 18:07 facebook-github-bot

@pedroerp merged this pull request in facebookincubator/velox@cc18f1dee01dfbe439b4b968ed092faeec520932.

facebook-github-bot avatar Jul 08 '24 19:07 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit cc18f1de.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Jul 08 '24 20:07 conbench-facebook[bot]