velox icon indicating copy to clipboard operation
velox copied to clipboard

Move freedBytes inside group reclaiming method

Open tanjialiang opened this issue 1 year ago • 2 comments

Move the freedBytes condition inside reclaiming method in shared arbitrator. At the same time rename targetBytes to requestBytes for future PR.

tanjialiang avatar Jul 02 '24 17:07 tanjialiang

Deploy Preview for meta-velox canceled.

Name Link
Latest commit aeaef23ba10e03fcc64c9bb8b9bb9f68b535fdbc
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/668b44961216f70008eaaef1

netlify[bot] avatar Jul 02 '24 17:07 netlify[bot]

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 02 '24 17:07 facebook-github-bot

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 08 '24 01:07 facebook-github-bot

@tanjialiang merged this pull request in facebookincubator/velox@562a7dc5578d6b924c674d22e591f4e923e12b9f.

facebook-github-bot avatar Jul 08 '24 17:07 facebook-github-bot

Conbench analyzed the 1 benchmark run on commit 562a7dc5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-facebook[bot] avatar Jul 08 '24 17:07 conbench-facebook[bot]