submitit icon indicating copy to clipboard operation
submitit copied to clipboard

Fix truncation of "Executor" in executor class name

Open tmct opened this issue 2 years ago • 4 comments

Noticed this while trying to make my own plugin/Executor... rstrip can remove too much!

tmct avatar Jun 22 '22 14:06 tmct

Hi @tmct!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jun 22 '22 14:06 facebook-github-bot

good catch ! Let me know if you need help with you Executor implementation.

To merge it, I'll just need you to sign the CLA, and to run the code formatter on your code

gwenzek avatar Jun 22 '22 14:06 gwenzek

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jun 22 '22 15:06 facebook-github-bot

Thank you - I'm glad that there is a method of adding custom Executor plugins!

tmct avatar Jun 24 '22 11:06 tmct

this has been here for quite some time and seems useful, so merging it ;)

jrapin avatar Aug 23 '22 15:08 jrapin