hsthrift icon indicating copy to clipboard operation
hsthrift copied to clipboard

Published 20 hours ago • verified publisher icon facebookincubator

Make cpp/wrap.h header only

Open rleshchinskiy opened this issue 2 years ago • 1 comments

This is used by some C++-only libraries and binaries (e.g., the C++ indexer) which we don't really want to depend on Haskell libs. We should probably move the C++ FFI bits into a separate lib but making it header-only for now is easy and might be the right thing to do anyway (the address comparisons we used to do might actually be dodgy with dynamic linking).

rleshchinskiy avatar Sep 10 '22 14:09 rleshchinskiy

This should be landed together with https://github.com/facebookincubator/Glean/pull/269 which tracks the change in Glean.

rleshchinskiy avatar Sep 11 '22 12:09 rleshchinskiy