gloo icon indicating copy to clipboard operation
gloo copied to clipboard

added <array> header

Open MatyushinMA opened this issue 4 years ago • 2 comments

When trying to build the lib on ubuntu with cmake using clang++-11 with libc++, the following error occurs:

/home/lib/pytorch/third_party/gloo/gloo/transport/tcp/device.cc:152:39: error: implicit instantiation of undefined template 'std::__1::array<char, 64>' std::array<char, HOST_NAME_MAX> hostname; ^ /usr/lib/llvm-10/bin/../include/c++/v1/__tuple:219:64: note: template is declared here template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;

which is because the header is absent in the gloo/transport/tcp/device.cc

MatyushinMA avatar Jan 16 '21 12:01 MatyushinMA

Hi @MatyushinMA!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 16 '21 12:01 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Jan 16 '21 12:01 facebook-github-bot