Rename RCCL_LIBRARY to RCCL_LIBRARY_PATH

[jithunnair-amd]

to avoid collision with variable in RCCL cmake file. This should fix the error about not finding "-lrccl" in https://github.com/pytorch/pytorch/pull/31341 (now refiled as https://github.com/pytorch/pytorch/pull/34683)

[facebook-github-bot]

Hi jithunnair-amd! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[jithunnair-amd]

@pietern Any guidance on the above CLA stuff?

[pietern]

@jithunnair-amd Checking in internally on how to proceed.

[jithunnair-amd]

@pietern Any update on this?

[pietern]

@jithunnair-amd We still require a CLA for repo's outside the pytorch org. I think AMD already has one, so it should be possible to whitelist. Can you check on your side?

[jithunnair-amd]

@pietern I signed the CLA, so this should be good to commit.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[jithunnair-amd]

@pietern Any concerns with merging this in?

[jeffdaily]

@xw285cornell are you able to land this?

[xw285cornell]

This diff is very old, could you rebase and trigger the tests again?

[jithunnair-amd]

@xw285cornell Done

[jithunnair-amd]

@xw285cornell Pinging post-holiday break

[jeffdaily]

@xw285cornell are we good now? Thanks.