SocketRocket icon indicating copy to clipboard operation
SocketRocket copied to clipboard

Add the callback of send operation.

Open NathanLi opened this issue 8 years ago • 7 comments

Add feature: Callback of send data.

NathanLi avatar Aug 14 '16 13:08 NathanLi

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

ghost avatar Aug 14 '16 13:08 ghost

I signed in CLA. Thank you.

NathanLi avatar Aug 15 '16 09:08 NathanLi

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ghost avatar Aug 15 '16 09:08 ghost

This looks like a nice idea, will review soon and provide some feedback on naming and polish so we can get this merged in!

nlutsenko avatar Aug 23 '16 22:08 nlutsenko

@nlutsenko Thank you for taking the time to review my code. I have changed you mentioned, please review again.

NathanLi avatar Nov 03 '16 15:11 NathanLi

Yes, you are right. Use dataRange as a key is correct.

NathanLi avatar Nov 09 '16 01:11 NathanLi

@nlutsenko Can you review the code?

NathanLi avatar Dec 29 '16 07:12 NathanLi