fix: allow for no gmaps_key input, add new parameters, fix .onLoad check
-
feat: Allow for users to use
commuting_zones()without the need of fetching the coordinates using Google's API. - feat: Enable new parameters: quiet, longitude_col_name, latitude_col_name, …
-
fix: .onLoad warning when checking the code with
devtools::check()
thanks a thousand:) while you're doing it already, can you also adapt the readme and the website (under website/doc/Walkthrough/Walkthrough.md), then I can deploy the website change too.
LGTM!
Currently testing the integration in GL, because it throws error when running:
GeoTestData_PreTest <- GeoDataRead(data = GeoLift_PreTest,
date_id = "date",
location_id = "location",
Y_id = "Y",
X = c(), #empty list as we have no covariates
format = "yyyy-mm-dd",
cluster_locations =T,
find_location_lat_long = T,
summary = TRUE,
country_name = "United States"
)
FYI @ArturoEsquerra @NicolasMatrices-v2 @JussanN @raphaeltamaki
@NicolasMatrices-v2 please check. Thanks for your comments and feedback. I tend to avoid stop() errors when not 100% necessary; this might be an example where that's the case.
@NicolasMatrices-v2 @gufengzhou any updates here? Are we ready to merge after the changes suggested?