AITemplate icon indicating copy to clipboard operation
AITemplate copied to clipboard

v0.1.1 reverted changes in detect_target.py

Open gexahedron opened this issue 2 years ago • 1 comments

Hi! there were 2 issues, about disabling T4 and supporting A10G: https://github.com/facebookincubator/AITemplate/pull/18 https://github.com/facebookincubator/AITemplate/issues/14 there was also a commit with changes in detect_target.py https://github.com/facebookincubator/AITemplate/pull/18 , however 0.1.1 reverted the changes - https://github.com/facebookincubator/AITemplate/commit/f7878c907167b41423d63e5355fc2685cda58f8e#diff-e72da6536390f9620c552bf13ab688627792777de93ddb19bd5cd9222b5c0200 Was it intentional?

gexahedron avatar Nov 21 '22 15:11 gexahedron

I think it is a mistake in sync between Meta internal AIT and OSS AIT.

I will fix it today.

Thanks for raising this issue.

On Mon, Nov 21, 2022 at 07:06 Nikolay Ulyanov @.***> wrote:

Hi! there were 2 issues, about disabling T4 and supporting A10G: #18 https://github.com/facebookincubator/AITemplate/pull/18 #14 https://github.com/facebookincubator/AITemplate/issues/14 there was also a commit with changes in detect_target.py #18 https://github.com/facebookincubator/AITemplate/pull/18 , however 0.1.1 reverted the changes. Was it intentional?

— Reply to this email directly, view it on GitHub https://github.com/facebookincubator/AITemplate/issues/97, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJTLXTGUNN3MNNFQNZG2S3WJOFZBANCNFSM6AAAAAASGXZDSQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Bing Xu

antinucleon avatar Nov 21 '22 15:11 antinucleon