AITemplate icon indicating copy to clipboard operation
AITemplate copied to clipboard

Published 20 hours ago • verified publisher icon facebookincubator

Avoid WSL requirement on Windows?

Open jammm opened this issue 1 year ago • 5 comments

I realize that you probably require the make tool (https://github.com/facebookincubator/AITemplate/issues/83#issuecomment-1312794318) which is only available proper in WSL, but on AMD platforms we do not support WSL with ROCm on Windows, so can we please have an alternative to WSL that would help AITemplate run on AMD for Windows?

jammm avatar Mar 23 '23 07:03 jammm

I'll try to add a support for Windows for the regular Visual Studio and CL compiler

alexanderguzhva avatar Mar 23 '23 17:03 alexanderguzhva

Thanks @alexanderguzhva ! That would be much appreciated.

jammm avatar Mar 23 '23 17:03 jammm

btw AIT doesn't run well on rocm even on Linux right now. There is an ongoing PR to support rocm on Linux: https://github.com/facebookincubator/AITemplate/pull/146.

cc @asroy, @fsx950223

ipiszy avatar Mar 23 '23 18:03 ipiszy

I was able to do a first successful compilation for MSVC + CUDA on Windows, will create a PR. I'll also try to test some simple AIT examples for ROCM and make sure that it compiles.

alexanderguzhva avatar Mar 27 '23 01:03 alexanderguzhva

@jammm Something has started breathing for my Windows+CMake+CUDA version, I'm getting certain unit tests passing and compiling. Please check #540 , file python/aitemplate/backend/cuda/builder_cmake.py and let's discuss the changes that I need to make for CMake templates inside this file in order to generalize builder_cmake.py for ROCM case. Some additional libraries that need to be included, compiler flags, etc. Thanks.

alexanderguzhva avatar Apr 22 '23 22:04 alexanderguzhva