AITemplate icon indicating copy to clipboard operation
AITemplate copied to clipboard

Upgrade compiler to ROCM 5.3 version

Open illsilin opened this issue 3 years ago • 4 comments

This change will upgrade the AMD ROCM compiler from a custom build of amd-stg-open branch to the official ROCM 5.3 release. Also, removed some python packages that are not needed here. This should reduce the size of the docker image, reduce build time, and simplify the installation. The performance will remain unchanged.

illsilin avatar Oct 06 '22 19:10 illsilin

Hi @illsilin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Oct 06 '22 19:10 facebook-github-bot

Thanks @illsilin! Please sign the CLA. Also could you sign off on the performance & correctness on all examples?

antinucleon avatar Oct 06 '22 20:10 antinucleon

Hi @antinucleon. We are currently working on getting the CLA signed on behalf of AMD. It may take a while. We did run all the tests and everything seems to work fine.

illsilin avatar Oct 06 '22 21:10 illsilin

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Nov 01 '22 22:11 facebook-github-bot