AITemplate icon indicating copy to clipboard operation
AITemplate copied to clipboard

Relax constraint on num_inputs

Open tissue3 opened this issue 2 years ago • 4 comments

Summary: Currently we don't allow AIT's inputs to be a subset of python's inputs. This could cause us some trouble. e.g. https://www.internalfb.com/phabricator/paste/view/P619446970?lines=37 Here, add_14 can be deduced at a very early stage and therefore the source of add_14: cat_37 actually isn't used in AIT graph anywhere! Therefore, we would got complaint: User passed 6 inputs, but the model expects 5. This is actually because cat_37 is not longer needed in AIT's graph! We can relax the constraint that AIT's inputs == python's inputs, as along as we can find each AIT's input can corresponding python's input.

Differential Revision: D43205927

tissue3 avatar Feb 11 '23 00:02 tissue3

This pull request was exported from Phabricator. Differential Revision: D43205927

facebook-github-bot avatar Feb 11 '23 00:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D43205927

facebook-github-bot avatar Feb 11 '23 00:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D43205927

facebook-github-bot avatar Feb 11 '23 01:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D43205927

facebook-github-bot avatar Feb 14 '23 08:02 facebook-github-bot