AITemplate icon indicating copy to clipboard operation
AITemplate copied to clipboard

Allow support for additional NVIDIA GPU types

Open space55 opened this issue 2 years ago • 5 comments

This commit will decode the compute capability from nvidia-smi, and allow _detect_cuda to return an appropriate value for GPUs other than the T4, V100, and A100 (such as the RTX A6000, A10, etc.).

Please let me know if any further modifications need to be made!

space55 avatar Jan 21 '23 06:01 space55

Hi @space55!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 21 '23 06:01 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jan 21 '23 07:01 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jan 21 '23 07:01 facebook-github-bot

Couple weeks ago it was a PR to use cuda-python API to get GPU Major and Minor Compute capability. It works better than nvidia-smi --query-gpu=compute_cap because compute_cap support was added to nvidia-smi only recently. It is not supported by cuda-11.4 which is used by CI.

apivovarov avatar Mar 17 '23 19:03 apivovarov

You diff has sanity check failure.

wushirong avatar Mar 22 '23 15:03 wushirong