Recoil icon indicating copy to clipboard operation
Recoil copied to clipboard

Optimizing functions 🚀

Open sanjaiyan-dev opened this issue 1 year ago • 11 comments

Memoizing functions using useCallback and useMemo for performance benefits :)

Extremely sorry if I made any mistakes :(

sanjaiyan-dev avatar Aug 08 '22 12:08 sanjaiyan-dev

@sanjaiyan-dev - Were you able to measure any performance gains with this change?

drarmstr avatar Aug 09 '22 02:08 drarmstr

@drarmstr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 09 '22 02:08 facebook-github-bot

@sanjaiyan-dev has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Sep 24 '22 02:09 facebook-github-bot

@sanjaiyan-dev has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Nov 02 '22 16:11 facebook-github-bot

Is there an update on this? We are still seeing that useRecoilValue is quite slow, it is making us consider using a different library

zacharyfmarion avatar Jun 29 '23 21:06 zacharyfmarion

Is there an update on this? We are still seeing that useRecoilValue is quite slow, it is making us consider using a different library

Hi, there are some code changes that need to be done from my side, but I don't know the current status or the maintainer's idea of merging them :(.

sanjaiyan-dev avatar Jun 30 '23 01:06 sanjaiyan-dev

This PR is completely broken. Can we just close it please.

FezVrasta avatar Jun 30 '23 05:06 FezVrasta

This PR is completely broken. Can we just close it please.

Okay :) Should I create a new PR then? (@FezVrasta)

sanjaiyan-dev avatar Jun 30 '23 05:06 sanjaiyan-dev

Considering you are mixing up useMemo and useCallback I'm afraid you may not have the required knowledge to contribute to this project at this time. Of course that's just my opinion observing what you wrote so far.

FezVrasta avatar Jun 30 '23 06:06 FezVrasta

Considering you are mixing up useMemo and useCallback I'm afraid you may not have the required knowledge to contribute to this project at this time. Of course that's just my opinion observing what you wrote so far.

Sorry and you are correct, Can you please clarify if I am correct, useCallback for memozing functions and useMemo for return values ? Hope I am correct :)

sanjaiyan-dev avatar Jun 30 '23 09:06 sanjaiyan-dev

Hi, anything new about this?

doublelam avatar Aug 01 '23 05:08 doublelam