prepack
prepack copied to clipboard
`__evaluatePureFunction` doesn't properly validate arguments
Prepacking the following crashes Prepack.
__evaluatePureFunction("boo");
In the implementation, it shouldn't check via an invariant
that the argument is a proper value, but instead it should throw a user-level exception or emit a CompilerDiagnostics
error.
Hey @NTillmann I am very new to open source contribution and I would love to work on this issue. Should I go ahead with it?
This one should be easy! Give it a try.
Sure. Will try it :)
PR for this issue: https://github.com/facebook/prepack/pull/2403
@NTillmann Can you please tell which error message I should add for this issues which will help a developer to understand the error https://github.com/facebook/prepack/wiki/Prepack-diagnostics
Just make up a new PP number that isn't used yet. Propose a wiki text in your PR, and then we'll create the wiki page for you when landing the PR.