Add error PP0036 for invalid property keys

[bernard-lin]

Release notes: Add error PP0036 for invalid property keys

Hi! I'm still very new this codebase and exploring it. Was this what you were thinking of in #1898, @NTillmann ?

[bernard-lin]

Got it, thanks!

Also, do you know what I have to do to run the ECMA-262 tests locally since the test262 folder links to another repo? Should I just clone that repo into that folder?

[hermanventer]

We don't seem to have an existing negative test case for this. The place to add new test would be in test/error-handler.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[bernard-lin]

@hermanventer, any tips on writing tests for abstract operations?

Would I use the __abstract operation? (e.g. __abstract('object', '({toString() { return "x"; } : 3})') I always seem to run into the invalid syntax error first.

Thanks for the help!

[hermanventer]

You would use __abstract. Look at test/error-handler/member2.js for inspiration.