esprima icon indicating copy to clipboard operation
esprima copied to clipboard

Let bin scripts use the correct npm module for esprima.

Open davidmccabe opened this issue 11 years ago • 3 comments

The scripts included with esprima in bin were importing the upstream esprima module, which goes by a different name in npm. This caused anybody using esprima from the command-line to confusingly lack JSX support.

davidmccabe avatar Oct 08 '14 22:10 davidmccabe

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

facebook-github-bot avatar Oct 08 '14 23:10 facebook-github-bot

I don't know what the right thing is, either. It seems crazy that you should have to change the code just because you changed the npm package name.

davidmccabe avatar Oct 09 '14 21:10 davidmccabe

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Oct 09 '14 22:10 facebook-github-bot