atomicfile icon indicating copy to clipboard operation
atomicfile copied to clipboard

Remove redundant if ...; err != nil checks

Open davidklassen opened this issue 7 years ago • 3 comments

Fixes golint warnings:

$ golint ./...
atomicfile.go:41:2: redundant if ...; err != nil check, just return error instead.
atomicfile.go:55:2: redundant if ...; err != nil check, just return error instead.

davidklassen avatar Dec 04 '17 07:12 davidklassen

It looks like vet command is no longer available under golang.org/x/tools/cmd package (see https://golang.org/doc/go1.2#go_tools_godoc). May be it makes sense to update go version in .travis.yml?

davidklassen avatar Dec 04 '17 07:12 davidklassen

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 04 '17 08:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Dec 04 '17 10:12 facebook-github-bot