atom-ide-ui icon indicating copy to clipboard operation
atom-ide-ui copied to clipboard

description always rendered for messages in panel

Open Arcanemagus opened this issue 8 years ago • 9 comments

Description

The description attribute of messages is being rendered in the panel, as this is a long form description that is meant to only be optionally shown on request of the user this causes issues.

Expected Behavior

description is only optionally shown.

Actual Behavior

The description is rendered directly after the excerpt, and is rendered as raw text.

Diagnostics

Renders the description in the list: image

As well as in the datatip (this only barely fits in a 1920x1080 monitor): image

linter-ui-default

No indication in the panel: image

Tooltip indicates that it can be expanded on the left side: image

When expanded it shows the full description: image

linter-ui-plus

Blue "3 dot" icon indicates additional information: image

When expanded it renders the description in the panel: image

Tooltips aren't implemented in linter-ui-plus.

Versions

  • Atom: v1.21.0-beta0
  • Client OS: Windows 10 x64
  • atom-ide-ui: 0.3.3

Additional Details

Installed packages
Dev Packages (103) C:\Users\Landon Abney\.atom\dev\packages
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

Community Packages (102) C:\Users\Landon Abney\.atom\packages
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

Arcanemagus avatar Sep 18 '17 01:09 Arcanemagus

Inside the table, this is only because you have "Full Description" checked right? I think normally it only shows the first line. I think the size/expandability of the datatip is something that may be addressed by @matthewwithanm's rewrite of the UI. I'll create a separate issue to track the lack of markdown (along with all the other missing features).

hansonw avatar Sep 18 '17 17:09 hansonw

The description for that setting is talking about traces (a little used feature of the v1 API), it definitely shouldn't be controlling description display as that was very much meant to be displayed only when requested (it was tested with entire web pages being rendered in there during development...).

But yes, I did have it enabled 😉.

Arcanemagus avatar Sep 18 '17 18:09 Arcanemagus

Ah we should rename the feature description. It also toggles displaying newlines in the table (note that it's not really a setting - it's toggled by the checkbox right inside the table).

hansonw avatar Sep 18 '17 18:09 hansonw

There is no checkbox in the panel controlling that setting btw, even when the experimental UI is enabled (at least in v0.3.3).

Arcanemagus avatar Sep 18 '17 18:09 Arcanemagus

It looks like the checkbox you were talking about has shown up in v0.4.0.

Arcanemagus avatar Sep 27 '17 23:09 Arcanemagus

@hansonw Actually, checking on this again it looks like this isn't just from having the "Full description" checked: image Everything after [Consider refactoring.] is part of the description and shouldn't be showing here.

Arcanemagus avatar Oct 02 '17 16:10 Arcanemagus

Just a note: The new UI in v0.5.0 still has this issue.

Arcanemagus avatar Oct 10 '17 16:10 Arcanemagus

Also, the Full description option only seems to control whether newlines are rendered in the panel for descriptions, not whether they show at all.

Off: image

On: image

Arcanemagus avatar Oct 10 '17 16:10 Arcanemagus

Just as an example of how annoying this is compared to the other implementations...

atom-ide-ui's giant wall of text: image

linter-ui-plus: image

linter-ui-default: image


The other implementations display a clean list of messages, with only the excerpt showing by default. atom-ide-ui displays a wall of text that takes far more attention to parse out the relevant information from.

I definitely don't consider this an enhancement, but a bug.

Arcanemagus avatar Oct 20 '17 17:10 Arcanemagus