atom-ide-ui icon indicating copy to clipboard operation
atom-ide-ui copied to clipboard

Datatip source code links

Open BoykoAlex opened this issue 7 years ago • 1 comments

Description

I have put a source link in the markdown contents of a datatip. Namely the Atom Core URL to open a file in Atom editor given its path: [This is a link](atom://core/open/file?filename=<path to file>) Atom Core links went in with #15935. I have also opened the same issue against core Atom #16888 I'm not exactly sure which package is responsible for this to work...

The problem is that ATom URL handlers are not supported in MD datatip/hover or any rendered MD

Expected Behavior

Should invoke Atom URL handler for atom:// URL

Actual Behavior

Nothing happens. Expects a http:// protocol which is handled by opening external browser

Versions

  • Atom: 1.25-beta2 and all predecessors
  • Client OS: Mac OSX
  • atom-ide-ui: 0.9.2

Additional Details

Looking for directions... What to look at if I am to provide a patch for this

BoykoAlex avatar Mar 06 '18 00:03 BoykoAlex

Markdown datatips are converted to HTML via marked here: https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-datatip/lib/MarkedStringDatatip.js#L32

If there are any parameters which would enable atom:// links to work, I'm open to merging that in!

hansonw avatar Mar 06 '18 00:03 hansonw