atom-ide-ui icon indicating copy to clipboard operation
atom-ide-ui copied to clipboard

Published 20 hours ago • verified publisher icon facebookarchive

Support for symbol rename?

Open rianneogi opened this issue 7 years ago • 6 comments
trafficstars

Is there going to be support for symbol renaming via textDocument/rename?

rianneogi avatar Jan 12 '18 09:01 rianneogi

related https://github.com/atom/atom-languageclient/issues/13

exploide avatar Jan 12 '18 17:01 exploide

We may look at this in the future, especially as we're considering adding additional refactoring APIs to the LSP (cc @hchau-fb). Nuclide has a generic refactoring UI we could bring in, but it's a bit overkill until the LSP has more than just rename.. I think we'd be open to someone implementing a really simple input dialog and exposing a rename service though. It depends on how @damieng and @daviwil want to prioritize this, I guess.

hansonw avatar Jan 16 '18 22:01 hansonw

I'd like for this too... I wonder how hard it'd be to implement

b-fuze avatar Mar 11 '18 00:03 b-fuze

@ConderS implemented this during his internship! We did end up bringing in the generic refactoring UI as well. See https://gfycat.com/gifs/detail/PrestigiousWelldocumentedAldabratortoise for a preview.

arxanas avatar Aug 13 '18 16:08 arxanas

How do we get this merged in so we can add support in atom-languageclient too?

damieng avatar Nov 14 '18 18:11 damieng

@damieng: It's already committed (e.g. in https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-refactor/lib/components/RenameComponent.js). Is that sufficient for your purposes?

Nuclide's LSP integration for rename is at https://github.com/facebook/nuclide/blob/ea943ace95f55de18eee60d3fe61cecabf5e1c9c/pkg/nuclide-vscode-language-service-rpc/lib/LspLanguageService.js#L1991

arxanas avatar Nov 15 '18 19:11 arxanas