atom-ide-ui icon indicating copy to clipboard operation
atom-ide-ui copied to clipboard

datatip highlight hides text selection

Open capi1O opened this issue 8 years ago • 4 comments

Description

When selecting text on a variable name, the selected text is hidden once the datatip highlight appears. When the mouse leaves the variable name area, the datatip highlight goes away and selected text is then visible.

By default the datatip highlight color it is the same than the syntax selection color, see https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-datatip/styles/datatip.less But the problem remains even when a different color is set, by overriding the CSS rule in atom styles.less as below :

atom-text-editor .datatip-highlight-region > .region {
  background: #363a40;
}

The selected text highlight is hidden as soon as the datatip shows.

Expected Behavior

variable name is highlighted when the datatip appears but currently the selected text is also still visible.

Versions

  • Atom: 1.22.0
  • Client OS: macOS 10.13
  • atom-ide-ui: Nuclide 0.264.0

Additional Details

  • Installed packages (apm ls --installed):

├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] (disabled) ├── [email protected] ├── [email protected] (disabled) ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] └── [email protected]

capi1O avatar Nov 11 '17 20:11 capi1O

I am assuming this is the one you are talking about. It is absolutely annoying and painful to look at. If not then I'd like to create another issue for this one! @monkeydri can you confirm ?! capture

thatbeardo avatar Nov 17 '17 11:11 thatbeardo

Hi @thatbeardo, no this is not the same issue (actually I don't have your green highlight diagnostics issue), see below for what I was talking about :

atom-ide-ui-datatip-select-highlight-bug

1- I start selecting showLabel 2- Once the datatip appears, the selection is not visible anymore because the while showLabel var is highlighted. 3- As soon as I hover out from the var name the selection is visible again (because the datatip and its strong highlight are gone).

From the GIF we can see that it is only when the mouser is over the var name that the selected text is not visible. Even with the var name highlight (without datatip) when the mouse is out the selected text is still visible. Once the datatip appears, the highlight become stronger and makes previously selected text invisible.

capi1O avatar Nov 21 '17 11:11 capi1O

As a work-around I did this:

atom-text-editor .datatip-highlight-region > .region {
  background: none;
}

It shows my selected text. Once the data tip appears, I see the desired flow info and even my selected text.

Mark-Schmeiser avatar Feb 09 '18 07:02 Mark-Schmeiser

Same problem here, pic shows before and after hovering mouse on Formatter. Marks work-around worked fine.

atom_python_ide

joost823 avatar Jun 02 '18 12:06 joost823